feat: experiment list batch [DET-3001] #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkang1
force-pushed
the
3001-experiment-list-batch
branch
from
b1a9d4f
to
02d6088
Compare
added 9 commits
July 14, 2020 12:51
hamidzr
reviewed
Jul 15, 2020
There was a problem hiding this comment.
Nice work here it looks great and we get an animation going on! I added some comments below
- kill triggered errors (stale state): I ran into a situation where the react view has stale state (because of polling) then trying to kill resulted in getting an error from the server. I'm not sure what we can do here with lack of streaming. I know with the new API I'm making these post endpoints idempotent thus it won't return an error and this would be a non issue.
- I could see people miss clicking the area around the row checkbox: could we have bigger input select area. or deactivate click handler for it? this was something we explicitly added to our Elm table. could be for future work but before we release the table?
I think we can't fulfill
For
View in TensorBoard- If ANY of the selected experiment can not be viewed in TensorBoard, disable the batchView in TensorBoardoperation.
with the information we currently get on this page.
activate is enabled when it seems it shouldn't
hamidzr
reviewed
Jul 15, 2020
Oops I had logic it always force it to be true while testing and forgot to remove it, thanks for catching this! |
hkang1
force-pushed
the
3001-experiment-list-batch
branch
2 times, most recently
from
e27782e
to
b0ccc27
Compare
hkang1
force-pushed
the
3001-experiment-list-batch
branch
from
b0ccc27
to
e70a404
Compare
hamidzr
approved these changes
Jul 17, 2020
hkang1
force-pushed
the
3001-experiment-list-batch
branch
from
e70a404
to
964df34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Plan
Commentary (optional)